Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add default_headers for Azure embedders #8699

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

feat: add default_headers for Azure embedders #8699

wants to merge 4 commits into from

Conversation

Amnah199
Copy link
Contributor

@Amnah199 Amnah199 commented Jan 9, 2025

Related Issues

Proposed Changes:

Replaces the old PR: #8535
Add default_headers parameter as a keyword argument to AzureOpenAIDocumentEmbedder and AzureOpenAITextEmbedder.

How did you test it?

Ran the tests and CI

Notes for the reviewer

Checklist

  • I have read the contributors guidelines and the code of conduct
  • I have updated the related issue with new insights and changes
  • I added unit tests and updated the docstrings
  • I've used one of the conventional commit types for my PR title: fix:, feat:, build:, chore:, ci:, docs:, style:, refactor:, perf:, test: and added ! in case the PR includes breaking changes.
  • I documented my code
  • I ran pre-commit hooks and fixed any issue

@github-actions github-actions bot added type:documentation Improvements on the docs topic:tests labels Jan 9, 2025
@Amnah199 Amnah199 mentioned this pull request Jan 9, 2025
Closed
@coveralls
Copy link
Collaborator

coveralls commented Jan 9, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 12698689155

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 34 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.002%) to 91.096%
Files with Coverage Reduction New Missed Lines %
components/embedders/azure_text_embedder.py 11 67.39%
components/embedders/azure_document_embedder.py 23 54.29%
Totals Coverage Status
Change from base Build 12696905998: 0.002%
Covered Lines: 8655
Relevant Lines: 9501
💛 - Coveralls

@Amnah199 Amnah199 marked this pull request as ready for review January 9, 2025 21:21
@Amnah199 Amnah199 requested review from a team as code owners January 9, 2025 21:21
@Amnah199 Amnah199 requested review from dfokina and anakin87 and removed request for a team January 9, 2025 21:21
anakin87
anakin87 approved these changes Jan 10, 2025
View reviewed changes
Copy link
Member

@anakin87 anakin87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

I would recommend adding a test_from_dict test case to both embedders and then merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anakin87 anakin87 anakin87 approved these changes

@dfokina dfokina Awaiting requested review from dfokina dfokina is a code owner automatically assigned from deepset-ai/documentation

Assignees
No one assigned
Labels
topic:tests type:documentation Improvements on the docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support default_headers for AzureOpenAIDocumentEmbedder and AzureOpenAITextEmbedder
3 participants
@Amnah199 @coveralls @anakin87